git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] refs.c: make ref_transaction_create a wrapper for ref_transaction_update

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 20, 2014, 18:03 UTC
Message-ID
<20141120180315.GA15945@google.com>
In-Reply-To
<20141120160000.GA31738@peff.net>
Jeff King wrote:
> On Wed, Nov 19, 2014 at 01:40:23PM -0800, Stefan Beller wrote:
Show 11 quoted lines
>> -	if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
>> -		strbuf_addf(err, "refusing to create ref with bad name %s",
>> -			    refname);
>> -		return -1;
>> -	}
>
> You claimed in the cover letter that only BUG messages were changed. But
> I think this third one is a real user-visible message.
>
> That being said, I think the sum total of the change to the message is
> s/create/update/, and it's probably fine.

Yeah, it we want to get the 'create' back, we could handle it by checking if old_sha1 is null_sha1 in transaction_update (that would take of other callers, too, like 'git update-ref <ref> <commit> ""'). But I haven't convinced myself that's worth the complication --- in any event it could be a separate patch to avoid blocking this one.

Thanks, Jonathan

Previous: Stefan BellerNext: Jeff King
Message 8 of 14 in “Breaking the ref-transactions-reflog series in smaller parts”
  1. 0/2 Breaking the ref-transactions-reflog series in smaller partsStefan Beller, Nov 19, 2014
  2. 1/2 refs.c: make ref_transaction_create a wrapper for ref_transaction_updateStefan Beller, Nov 19, 2014
  3. Jonathan NiederNov 20, 2014
  4. Stefan BellerNov 20, 2014
  5. Jonathan NiederNov 20, 2014
  6. Jeff KingNov 20, 2014
  7. 1/2 refs.c: make ref_transaction_create a wrapper for ref_transaction_updateStefan Beller, Nov 20, 2014
  8. Jonathan NiederNov 20, 2014
  9. Jeff KingNov 20, 2014
  10. 2/2 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateStefan Beller, Nov 19, 2014
  11. Jonathan NiederNov 20, 2014
  12. 2/2 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateStefan Beller, Nov 20, 2014
  13. Junio C HamanoNov 20, 2014
  14. Michael HaggertyNov 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.