git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v13 11/11] Documentation: add documentation for 'git interpret-trailers'

From
Marc Branchaud <marcnarc@xiplink.com>
Date
Aug 21, 2014, 14:16 UTC
Message-ID
<53F5FF4E.5090009@xiplink.com>
In-Reply-To
<CAP8UFD3hi6rRS=Z9dvbpvW75_K5mN5mPaxQdx3ATYOwXbuw3Pw@mail.gmail.com>
On 14-08-20 11:39 PM, Christian Couder wrote:
Show 10 quoted lines
> On Thu, Aug 21, 2014 at 12:05 AM, Marc Branchaud <marcnarc@xiplink.com> wrote:
>> On 14-08-16 12:06 PM, Christian Couder wrote:
>>> +
>>> +* after them it's only possible to have some lines that contain only
>>> +  spaces, and then a patch; the patch part is recognized using the
>>> +  fact that its first line starts with '---' (three minus signs),
>>
>> Is that "starts with" or "consists solely of"?
> 
> It is starts with. (The starts_with() function is used.)

Wouldn't it be more robust to do it the other way? I can imagine cases when a human might want to start a line of text with "---", whereas we can make sure that git tools always use a plain "---" line with no extra text.

Not a big deal either way though.  Thanks for working on this!
		M.
Previous: Christian CouderNext: Christian Couder
Message 15 of 18 in “Add interpret-trailers builtin”
  1. 00/11 Add interpret-trailers builtinChristian Couder, Aug 16, 2014
  2. 01/11 trailer: add data structures and basic functionsChristian Couder, Aug 16, 2014
  3. 02/11 trailer: process trailers from input message and argumentsChristian Couder, Aug 16, 2014
  4. 03/11 trailer: read and process config informationChristian Couder, Aug 16, 2014
  5. 04/11 trailer: process command line trailer argumentsChristian Couder, Aug 16, 2014
  6. 05/11 trailer: parse trailers from file or stdinChristian Couder, Aug 16, 2014
  7. 06/11 trailer: put all the processing together and printChristian Couder, Aug 16, 2014
  8. 07/11 trailer: add interpret-trailers commandChristian Couder, Aug 16, 2014
  9. 08/11 trailer: add tests for "git interpret-trailers"Christian Couder, Aug 16, 2014
  10. 09/11 trailer: execute command from 'trailer.<name>.command'Christian Couder, Aug 16, 2014
  11. 10/11 trailer: add tests for commands in config fileChristian Couder, Aug 16, 2014
  12. 11/11 Documentation: add documentation for 'git interpret-trailers'Christian Couder, Aug 16, 2014
  13. Marc BranchaudAug 20, 2014
  14. Christian CouderAug 21, 2014
  15. Marc BranchaudAug 21, 2014
  16. Christian CouderAug 16, 2014
  17. Junio C HamanoSep 3, 2014
  18. Christian CouderSep 15, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.