From: Marc Branchaud <marcnarc@xiplink.com>
Date: Thu, 21 Aug 2014 14:16:46 GMT
Subject: Re: [PATCH v13 11/11] Documentation: add documentation for 'git interpret-trailers'
Message-ID: <53F5FF4E.5090009@xiplink.com>
In-Reply-To: <CAP8UFD3hi6rRS=Z9dvbpvW75_K5mN5mPaxQdx3ATYOwXbuw3Pw@mail.gmail.com>

On 14-08-20 11:39 PM, Christian Couder wrote:
> On Thu, Aug 21, 2014 at 12:05 AM, Marc Branchaud <marcnarc@xiplink.com> wrote:
>> On 14-08-16 12:06 PM, Christian Couder wrote:
>>> +
>>> +* after them it's only possible to have some lines that contain only
>>> +  spaces, and then a patch; the patch part is recognized using the
>>> +  fact that its first line starts with '---' (three minus signs),
>>
>> Is that "starts with" or "consists solely of"?
> 
> It is starts with. (The starts_with() function is used.)

Wouldn't it be more robust to do it the other way?  I can imagine cases when
a human might want to start a line of text with "---", whereas we can make
sure that git tools always use a plain "---" line with no extra text.

Not a big deal either way though.  Thanks for working on this!

		M.