Re: [PATCH v13 00/11] Add interpret-trailers builtin

From: Christian Couder <christian.couder@gmail.com>
Date: Aug 16, 2014, 22:25 UTC
Message-ID: <CAP8UFD2ta53VyEo=5AQ=W+EF4sOKzRUT=Ew26oz0CKHg9A7PXQ@mail.gmail.com>
In-Reply-To: <20140816153440.18221.29179.chriscool@tuxfamily.org>

On Sat, Aug 16, 2014 at 6:06 PM, Christian Couder <chriscool@tuxfamily.org> wrote:

Show 21 quoted lines

>
> 3) Changes since version 12, thanks to Jakub, Michael, Johan and Junio:
>
> * "end" and "start" values for "trailer.<token>.where" have been
>   implemented
> * "end" has been made the default value for "where", but this default
>   value can be changed using the new "trailer.where" config
>   variable
> * "addIfDifferentNeighbor" is now the default value for "ifexists",
>   but this default can be changed using the new "trailer.ifexists"
>   config variable
> * the new "trailer.ifmissing" can be used to change the default value
>   for "ifmissing" (which is "add")
> * by default the only separator is ':', this can be changed by using
>   the new "trailer.separators" config variable
> * only the configured separators (or just ':' by default) are used for
>   both input parsing and output printing; the only exception is that
>   '=' is always accepted as separator when parsing
>   "--trailer '<token><sep><value>'" command line arguments, for
>   compatibility with other git commands
> * 14 tests have been added

I forgot the following change:

* "overwrite" value for "ifexists" option has been replaced with
  "replace" value; when used with "where = after" or
  "where = before", "replace" does the same thing as "overwrite"
  did; but when used with "where = end" or "where = start", the
  new trailer appears at the end or the start of the existing trailers,
  instead of where the replaced trailer was