Re: [PATCH v13 00/11] Add interpret-trailers builtin

From: Christian Couder <chriscool@tuxfamily.org>
Date: Sep 15, 2014, 06:04 UTC
Message-ID: <20140915.080429.1739849931027469667.chriscool@tuxfamily.org>
In-Reply-To: <xmqqk35kwfvy.fsf@gitster.dls.corp.google.com>

From: Junio C Hamano <gitster@pobox.com>

Show 9 quoted lines

> Christian Couder <chriscool@tuxfamily.org> writes:
> 
>>   '=' is always accepted as separator when parsing
>>   "--trailer '<token><sep><value>'" command line arguments, for
>>   compatibility with other git commands
> 
> Hmph.  Which of other commands take "--option foo=bar"?
> 
> Puzzled...

Most commands accept "--option=value". I know that it is different from "--option foo=bar", but it could reduce user mistakes if we also accept "--trailer foo=bar".

And if we accept it, then whatever the user has configured in the "trailer.separators" option, "--trailer foo=bar" will always work and add the default separator. So it is a generic way to add "foo<separator> bar" to the trailers whatever the user want as a separator.

But maybe I should reword the documentation to add this reason. (I did not do that in the v14 series I just sent.)

Thanks, Christian.