Re: [PATCH 1/2] test-lib: tests skipped by GIT_SKIP_TESTS say so

From: Ilya Bobyr <ilya.bobir@gmail.com>
Date: Mar 3, 2014, 23:08 UTC
Message-ID: <53150B8A.9050709@gmail.com>
In-Reply-To: <C65A743B56974711A3806272E9B2C1DD@PhilipOakley>

On 3/3/2014 7:11 AM, Philip Oakley wrote:

Show 5 quoted lines

> From: "Ilya Bobyr" <ilya.bobyr@gmail.com>
>> We used to show "(missing )" next to tests skipped because they are
>> specified in GIT_SKIP_TESTS.  Use "(matched by GIT_SKIP_TESTS)" instead.
>
> The message below forgets the "by".

I'll fix the commit message. I think the output is long enough, while "by" does not add any information.

> Otherwise looks sensible.

Thanks for looking at it :)

Show 22 quoted lines

>
>> ---
>> t/test-lib.sh |   13 ++++++++-----
>> 1 files changed, 8 insertions(+), 5 deletions(-)
>>
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index 1531c24..89a405b 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -446,25 +446,28 @@ test_finish_ () {
>>
>> test_skip () {
>>  to_skip=
>> + skipped_reason=
>>  if match_pattern_list $this_test.$test_count $GIT_SKIP_TESTS
>>  then
>>  to_skip=t
>> + skipped_reason="matched GIT_SKIP_TESTS"
>
> s/matched GIT_SKIP_TESTS/matched by GIT_SKIP_TESTS/
>
>>  [...]