git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] Fix "repack --window-memory=4g" regression in 1.8.4

From
Stefan Beller <stefanbeller@googlemail.com>
Date
Jan 22, 2014, 22:33 UTC
Message-ID
<52E04741.6040403@googlemail.com>
In-Reply-To
<1390420685-18449-1-git-send-email-gitster@pobox.com>
On 22.01.2014 20:58, Junio C Hamano wrote:
Show 19 quoted lines
> The command line parser was broken when the command was
> reimplemented in C in two ways.  It incorrectly limited the value
> range of window-memory and max-pack-size to "int", and also stopped
> grokking the unit suffixes like 2g/400m/8k.
> 
> These two patches apply on top of 35c14176 (Reword repack
> documentation to no longer state it's a script, 2013-10-19) and
> later can be merged down to maint-1.8.4 track and upwards.
> 
> Junio C Hamano (2):
>   parse-options: refactor human-friendly-integer parser out of pack-objects
>   repack: accept larger window-memory and max-pack-size
> 
>  builtin/pack-objects.c | 25 ++++---------------------
>  builtin/repack.c       | 12 ++++++------
>  parse-options.c        | 17 +++++++++++++++++
>  parse-options.h        |  5 +++++
>  4 files changed, 32 insertions(+), 27 deletions(-)
> 

I recall we had a discussion about parsing as the shell script just passed them on without altering the argument, while the new c implementation parses the numbers already before passing them on.

Junio, thanks for such a quick patch. I'd currently have only little time for open source contributions.

The patches seems reasonable to me.

Thanks, Stefan

Previous: Junio C Hamano
Message 14 of 14 in “git repack --max-pack-size broken in git-next”
  1. Siddharth AgarwalJan 21, 2014
  2. Junio C HamanoJan 21, 2014
  3. Junio C HamanoJan 21, 2014
  4. 0/2 Fix "repack --window-memory=4g" regression in 1.8.4Junio C Hamano, Jan 22, 2014
  5. 1/2 parse-options: refactor human-friendly-integer parser out of pack-objectsJunio C Hamano, Jan 22, 2014
  6. 2/2 repack: accept larger window-memory and max-pack-sizeJunio C Hamano, Jan 22, 2014
  7. Jeff KingJan 23, 2014
  8. Jeff KingJan 23, 2014
  9. 1/3 repack: fix typo in max-pack-size optionJeff King, Jan 23, 2014
  10. 2/3 repack: make parsed string options const-correctJeff King, Jan 23, 2014
  11. 3/3 repack: propagate pack-objects options as stringsJeff King, Jan 23, 2014
  12. Jeff KingJan 23, 2014
  13. Junio C HamanoJan 23, 2014
  14. Stefan BellerJan 22, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.