Re: [PATCH 3/3] repack: propagate pack-objects options as strings

From: Jeff King <peff@peff.net>
Date: Jan 23, 2014, 01:38 UTC
Message-ID: <20140123013847.GD17254@sigill.intra.peff.net>
In-Reply-To: <20140123013008.GC19472@sigill.intra.peff.net>

On Wed, Jan 22, 2014 at 08:30:13PM -0500, Jeff King wrote:

> -		OPT_INTEGER(0, "window", &window,
> +		OPT_STRING(0, "window", &window, N_("n"),
>  				N_("size of the window used for delta compression")),

By the way, the old code with OPT_INTEGER would always say "n" here, so there is no change to "git repack -h" output here...

> -             OPT_INTEGER(0, "max-pack-size", &max_pack_size,
> +             OPT_STRING(0, "max-pack-size", &max_pack_size, N_("bytes"),
>                               N_("maximum size of each packfile")),

...but this one will now say:

    --max-pack-size <bytes>
                          maximum size of each packfile

I think that is more descriptive, but pack-objects does just say "n". I am OK with it either way.

-Peff