[PATCH v2 0/2] Fix "repack --window-memory=4g" regression in 1.8.4
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 22, 2014, 19:58 UTC
- Message-ID
- <1390420685-18449-1-git-send-email-gitster@pobox.com>
- In-Reply-To
- <xmqqzjmprlbq.fsf@gitster.dls.corp.google.com>
The command line parser was broken when the command was reimplemented in C in two ways. It incorrectly limited the value range of window-memory and max-pack-size to "int", and also stopped grokking the unit suffixes like 2g/400m/8k.
These two patches apply on top of 35c14176 (Reword repack documentation to no longer state it's a script, 2013-10-19) and later can be merged down to maint-1.8.4 track and upwards.
Junio C Hamano (2): parse-options: refactor human-friendly-integer parser out of pack-objects repack: accept larger window-memory and max-pack-size
builtin/pack-objects.c | 25 ++++--------------------- builtin/repack.c | 12 ++++++------ parse-options.c | 17 +++++++++++++++++ parse-options.h | 5 +++++ 4 files changed, 32 insertions(+), 27 deletions(-)
-- 1.9-rc0-151-ga5225c0