git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] submodule: fix confusing variable name

From
Mark Levedahl <mlevedahl@gmail.com>
Date
Aug 11, 2013, 19:53 UTC
Message-ID
<5207EBD2.6050802@gmail.com>
In-Reply-To
<5203D8F6.2020102@ramsay1.demon.co.uk>
On 08/08/2013 01:44 PM, Ramsay Jones wrote:
Show 19 quoted lines
> Fredrik Gustafsson wrote:
>> On Sun, Aug 04, 2013 at 07:34:48PM +0200, Jens Lehmann wrote:
>>> But we'll have to use sm_path here (like everywhere else in the
>>> submodule script), because we'll run into problems under Windows
>>> otherwise (see 64394e3ae9 for details). Apart from that the patch
>>> is fine.
>>
>> We're still using path= in the foreach-script. Or rather, we're setting
>> it. From what I can see and from the commit message 64394e3ae9 it could
>> possible be a problem.
>
> Please do not use a $path variable in any script intended to be run on
> windows; those poor souls who would otherwise have to fix the bugs will
> thank you! :-D
>
> Actually, it's not so much the use of a $path variable, rather the act
> of _exporting_ such a variable that causes the problem. (Which is why
> using $path with eval_gettext[ln] is such a problem, of course.)
>

Please note that especially in this case, Cygwin != Windows. Cygwin allows $path, $Path, $PATH, etc., to all coexist and be accessed case sensitively. Exporting $path causes no problem, either. Should the eval invoke a Windows program, $PATH is converted to Windows format and exported, the other case-sensitive variants of path remain in the environment and can be accessed by any program implementing case-sensitive lookup as well. Not sure what will happen with case-insensitive lookups, but a quick test showed that cmd.exe is not bothered by $path given $PATH exists.

Mark
Previous: Junio C HamanoNext: brian m. carlson
Message 10 of 17 in “Don't print status output with submodule.<name>.ignore=all”
  1. brian m. carlsonAug 3, 2013
  2. 1/2 submodule: fix confusing variable namebrian m. carlson, Aug 3, 2013
  3. Jonathan NiederAug 3, 2013
  4. Jens LehmannAug 4, 2013
  5. Fredrik GustafssonAug 4, 2013
  6. Jens LehmannAug 6, 2013
  7. Ramsay JonesAug 8, 2013
  8. Fredrik GustafssonAug 9, 2013
  9. Junio C HamanoAug 9, 2013
  10. Mark LevedahlAug 11, 2013
  11. 2/2 submodule: don't print status output with ignore=allbrian m. carlson, Aug 3, 2013
  12. Jonathan NiederAug 3, 2013
  13. Jens LehmannAug 4, 2013
  14. brian m. carlsonAug 10, 2013
  15. brian m. carlsonAug 11, 2013
  16. Jonathan NiederAug 11, 2013
  17. brian m. carlsonAug 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.