Re: [PATCH 2/2] submodule: don't print status output with ignore=all

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Aug 17, 2013, 16:27 UTC
Message-ID: <20130817162725.GE64402@vauxhall.crustytoothpaste.net>
In-Reply-To: <20130811160316.GE164436@vauxhall.crustytoothpaste.net>

On Sun, Aug 11, 2013 at 04:03:17PM +0000, brian m. carlson wrote:

Show 9 quoted lines

> On Sat, Aug 03, 2013 at 11:24:20AM -0700, Jonathan Nieder wrote:
> > If I just renamed a submodule, will 'module_name "$path"' do the right
> > thing with the old path?
> 
> module_name uses whatever's in .gitmodules.  I'm not sure what you mean
> by "renamed a submodule", since "git mv foo bar" fails with:
> 
>   vauxhall ok % git mv .vim/bundle/ctrlp .vim/bundle/ctrlq
>   fatal: source directory is empty, source=.vim/bundle/ctrlp, destination=.vim/bundle/ctrlq

Okay, I've tested this against next and it seems that the code handles it properly (at least I think it does). I left the following code

  # Always show modules deleted or type-changed (blob<->module)
  test $status = D -o $status = T && echo "$sm_path" && continue

before the ignore code, so I adjusted the new ignore code so that it prints both the new and the old path. I don't know that it's possible to print neither in that case, since we no longer can look up the old path in .gitmodules. I'll be sending my reroll shortly.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187