git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] submodule: fix confusing variable name

From
Jens Lehmann <jens.lehmann@web.de>
Date
Aug 4, 2013, 17:34 UTC
Message-ID
<51FE90B8.8030203@web.de>
In-Reply-To
<20130803181415.GF2893@elie.Belkin>
Am 03.08.2013 20:14, schrieb Jonathan Nieder:
Show 8 quoted lines
> brian m. carlson wrote:
> 
>> cmd_summary reads the output of git diff, but reads in the submodule
>> path into a variable called name.  Since this variable does not
>> contain the name of the submodule, but the path, rename it to be
>> clearer what data it actually holds.
> 
> Nice.

I totally agree. Paths and names of submodules are often confused (especially as they are identical for a submodule that was never moved), so cleaning up our sources so they use the correct term is The Right Thing.

But we'll have to use sm_path here (like everywhere else in the submodule script), because we'll run into problems under Windows otherwise (see 64394e3ae9 for details). Apart from that the patch is fine.

Previous: Jonathan NiederNext: Fredrik Gustafsson
Message 4 of 17 in “Don't print status output with submodule.<name>.ignore=all”
  1. brian m. carlsonAug 3, 2013
  2. 1/2 submodule: fix confusing variable namebrian m. carlson, Aug 3, 2013
  3. Jonathan NiederAug 3, 2013
  4. Jens LehmannAug 4, 2013
  5. Fredrik GustafssonAug 4, 2013
  6. Jens LehmannAug 6, 2013
  7. Ramsay JonesAug 8, 2013
  8. Fredrik GustafssonAug 9, 2013
  9. Junio C HamanoAug 9, 2013
  10. Mark LevedahlAug 11, 2013
  11. 2/2 submodule: don't print status output with ignore=allbrian m. carlson, Aug 3, 2013
  12. Jonathan NiederAug 3, 2013
  13. Jens LehmannAug 4, 2013
  14. brian m. carlsonAug 10, 2013
  15. brian m. carlsonAug 11, 2013
  16. Jonathan NiederAug 11, 2013
  17. brian m. carlsonAug 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.