Re: [PATCH 1/2] submodule: fix confusing variable name

From: Jens Lehmann <jens.lehmann@web.de>
Date: Aug 6, 2013, 17:33 UTC
Message-ID: <5201335C.5040001@web.de>
In-Reply-To: <20130804212938.GL19369@paksenarrion.iveqy.com>

Am 04.08.2013 23:29, schrieb Fredrik Gustafsson:

Show 9 quoted lines

> On Sun, Aug 04, 2013 at 07:34:48PM +0200, Jens Lehmann wrote:
>> But we'll have to use sm_path here (like everywhere else in the
>> submodule script), because we'll run into problems under Windows
>> otherwise (see 64394e3ae9 for details). Apart from that the patch
>> is fine.
> 
> We're still using path= in the foreach-script. Or rather, we're setting
> it. From what I can see and from the commit message 64394e3ae9 it could
> possible be a problem.

The commit message of 64394e3ae9 explicitly talks about that one:

  We note that the foreach subcommand provides $path to user scripts
  (ie it is part of the API), so we can't simply rename it to $sm_path.

> Not sure how to solve it though... Just a simple correction would break
> all script depending on that.

That's exactly why that one is still there. We could deprecate it in favor of $sm_path and remove it some time later, but I'm not convinced it is an urgent issue. But me thinks the documentation of foreach should be updated, as it still talks about $path.