git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Remove old forgotten command: whatchanged

From
Stefan Beller <stefanbeller@googlemail.com>
Date
Aug 7, 2013, 21:50 UTC
Message-ID
<5202C109.6040209@googlemail.com>
In-Reply-To
<7vtxj1crv6.fsf@alter.siamese.dyndns.org>
On 08/07/2013 07:50 PM, Junio C Hamano wrote:
Show 29 quoted lines
> Stefan Beller <stefanbeller@googlemail.com> writes:
> 
>> I'd deprecate it first for a year or such and remove it then.
>> In the meantime we could implement already remove the code
>> and change it to:
>>
>> + int cmd_whatchanged(int argc, const char **argv, const char *prefix)
>> + {
>> + 	return cmd_log(argc, argv, prefix)
>> + }
>>
>> Also we should make sure everything git whatchanged can do,
>> can easily be done with git log <options>.
> 
> That's even worse than "deprecating".
> 
> Your first step already changes the behaviour for people who really
> use the command, without telling them _why_ the behaviour has
> suddenly changed at all, while not helping *ANYBODY*.
> 
> The only thing it does is to scratch an irrelevant itch by people
> who peek the codebase and find an old command whose existence does
> not even hurt them.  They may have too much time on their hand, but
> that is not an excuse to waste other people's time by adding extra
> makework on our plate, or changing the behaviour for people who use
> the command without explanation.
> 
> Feeling irritated somewhat...
> 

Well if we make sure the whatchanged command can easily be reproduced with the log command, we could add the missing parameters to it, hence no change for the user. (git whatchanged == git log --raw --no-merges or git log --wc [to be done yet]).

So I did not mean to introduce a change for users!
But in general I like the idea to *remove* lines of code.
Stefan
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 31 in “Remove old forgotten command: whatchanged”
  1. Ramkumar RamachandraAug 7, 2013
  2. Stefan BellerAug 7, 2013
  3. Junio C HamanoAug 7, 2013
  4. Stefan BellerAug 7, 2013
  5. Junio C HamanoAug 8, 2013
  6. Ramkumar RamachandraAug 8, 2013
  7. Matthieu MoyAug 8, 2013
  8. Ramkumar RamachandraAug 8, 2013
  9. Matthieu MoyAug 8, 2013
  10. Junio C HamanoAug 8, 2013
  11. whatchanged: document its historical natureJunio C Hamano, Aug 9, 2013
  12. John KeepingAug 9, 2013
  13. Junio C HamanoAug 9, 2013
  14. John KeepingAug 12, 2013
  15. Junio C HamanoAug 13, 2013
  16. Ramkumar RamachandraAug 10, 2013
  17. Damien RobertAug 8, 2013
  18. Ramkumar RamachandraAug 8, 2013
  19. Matthieu MoyAug 8, 2013
  20. John KeepingAug 8, 2013
  21. Junio C HamanoAug 8, 2013
  22. Matthieu MoyAug 9, 2013
  23. Junio C HamanoAug 9, 2013
  24. Matthieu MoyAug 13, 2013
  25. Junio C HamanoAug 13, 2013
  26. Junio C HamanoAug 8, 2013
  27. Damien RobertAug 9, 2013
  28. Junio C HamanoAug 9, 2013
  29. Kyle J. McKayAug 7, 2013
  30. John KeepingAug 7, 2013
  31. Kyle J. McKayAug 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.