Re: Remove old forgotten command: whatchanged
- From
Kyle J. McKay <mackyle@gmail.com>
- Date
- Aug 7, 2013, 18:01 UTC
- Message-ID
- <4EE8B37B-F6A1-4BC4-9151-8546868E60A5@gmail.com>
- In-Reply-To
- <CALkWK0=zZKTwn7cdrJXsVXH-rF=xWMeD_z2XAOCnuaf2bK_h8Q@mail.gmail.com>
On Aug 7, 2013, at 09:00, Ramkumar Ramachandra wrote:
Show 32 quoted lines
> Hi,
>
> This is the difference between whatchanged and log:
>
> diff --git a/whatchanged b/log
> index fa1b223..004d9aa 100644
> --- a/tmp/whatchanged
> +++ b/tmp/log
> @@ -1,4 +1,4 @@
> -int cmd_whatchanged(int argc, const char **argv, const char *prefix)
> +int cmd_log(int argc, const char **argv, const char *prefix)
> {
> struct rev_info rev;
> struct setup_revision_opt opt;
> @@ -7,13 +7,10 @@ int cmd_whatchanged(int argc, const char **argv,
> const char *prefix)
> git_config(git_log_config, NULL);
>
> init_revisions(&rev, prefix);
> - rev.diff = 1;
> - rev.simplify_history = 0;
> + rev.always_show_header = 1;
> memset(&opt, 0, sizeof(opt));
> opt.def = "HEAD";
> opt.revarg_opt = REVARG_COMMITTISH;
> cmd_log_init(argc, argv, prefix, &rev, &opt);
> - if (!rev.diffopt.output_format)
> - rev.diffopt.output_format = DIFF_FORMAT_RAW;
> return cmd_log_walk(&rev);
> }
>
> Should we remove it?I use it all the time. Is there some log option to get exactly the same output? It doesn't appear that there is. The closest looks like "log --name-status" but it omits the modes and hash values.