Re: [RFC/PATCH 0/1] cygwin: Remove the Win32 l/stat() functions
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Jun 27, 2013, 22:17 UTC
- Message-ID
- <51CCB9E5.3010907@ramsay1.demon.co.uk>
- In-Reply-To
- <20130626223552.GA12785@sigill.intra.peff.net>
Jeff King wrote:
> On Wed, Jun 26, 2013 at 10:45:48PM +0100, Ramsay Jones wrote:
[ ... ]
Show 9 quoted lines
> I think Michael's assessment above is missing one thing. It is true that > a false positive is just a performance problem in most cases, as we > unnecessarily reload the file, thinking it has changed. > > However, when we have taken a lock on the file, there is an additional > safety measure: if we find the file is changed, we abort, as that should > never happen (it means somebody else modified the file while we had it > locked). But of course Cygwin's false positive here triggers the safety > valve, and we die without even realizing that nothing changed.
Indeed, this is exactly the situation.
ATB, Ramsay Jones