Re: [RFC/PATCH 0/1] cygwin: Remove the Win32 l/stat() functions

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Jun 26, 2013, 21:54 UTC
Message-ID: <51CB62FC.4070001@ramsay1.demon.co.uk>
In-Reply-To: <51CAF863.4020803@web.de>

Torsten Bögershausen wrote:

Show 14 quoted lines

> On 2013-06-25 23.18, Junio C Hamano wrote:
>> Johannes Sixt <j6t@kdbg.org> writes:
>>
>>> Some context: This is about a patch by Ramsay that removes the
>>> "schizophrenic lstat" hack for Cygwin. Junio, can you please queue that
>>> patch in pu?
>>
>> Sure.  Thanks.
> 
> First of all,
> thanks for the work.
> 
> Here some "benchmark" results, 
> (The test run of the test suite did the same amout of time).

The test suite runs noticeably faster for me.

Show 7 quoted lines

> 
> But:
> git status -uno in real life takes double the time,
> git 1.8.3 compared against "pu with the vanilla l/stat"
>    
>     1 second ->  2 seconds on linux kernel
> 0.2 seconds -> 0.4 seconds on git.git

Hmm, OK, I guess I will have to try something else. Sigh :(

> Do we have any known problems with the current implementation ?

Yes. The next branch is currently broken. (see reply to Junio)

> Does speed matter ?
> 
> One vote to keep the special cygwin functions.
> (And have a look how to improve the core.filemode)

I don't understand this (parenthetical) comment; could you elaborate on this.

ATB, Ramsay Jones