Re: [RFC/PATCH 0/1] cygwin: Remove the Win32 l/stat() functions
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Jul 11, 2013, 17:31 UTC
- Message-ID
- <51DEEC0A.9060001@ramsay1.demon.co.uk>
- In-Reply-To
- <51DBEDAF.30708@web.de>
Torsten Bögershausen wrote:
> On 30.06.13 19:28, Ramsay Jones wrote:
[ ... ]
Show 37 quoted lines
>>> You have just described my second patch! :D >> Unfortunately, I have not had any time to work on the patch this weekend. >> However, despite the patch being a bit rough around the edges, I decided >> to send it out (see below) to get some early feedback. >> >> Note that it passes the t3210, t3211, t5500, t3200, t3301, t7606 and t1301 >> tests, but I have not run the full test suite. >> >> Comments welcome. >> >> ATB, >> Ramsay Jones >> >> -- >8 -- >> Subject: [PATCH] cygwin: Add fast_[l]stat() functions >> >> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> >> --- >> builtin/apply.c | 6 +++--- >> builtin/commit.c | 2 +- >> builtin/ls-files.c | 2 +- >> builtin/rm.c | 2 +- >> builtin/update-index.c | 2 +- >> check-racy.c | 2 +- >> compat/cygwin.c | 12 ------------ >> compat/cygwin.h | 10 +++------- >> diff-lib.c | 2 +- >> diff.c | 2 +- >> entry.c | 4 ++-- >> git-compat-util.h | 13 +++++++++++-- >> help.c | 5 +---- >> path.c | 9 +-------- >> preload-index.c | 2 +- >> read-cache.c | 6 +++--- >> unpack-trees.c | 8 ++++---- >> 17 files changed, 36 insertions(+), 53 deletions(-) >>
[ ... ]
Show 21 quoted lines
> I managed to apply your patch on next, and run the test suite before and after > your patch. > The performance running "git status" on a linux kernel is the same as in v1.8.3. > > Running test suite did not show new failures. > The following test cases had failed, and are fixed now: > < t1400-update-ref > < t3210-pack-refs > < t3211-peel-ref > < t3306-notes-prune > < t5304-prune > < t5404-tracking-branches > < t5500-fetch-pack > < t5505-remote > < t5514-fetch-multiple > < t5515-fetch-merge-logic > < t6030-bisect-porcelain > < t9300-fast-import > < t9903-bash-prompt > > In short: Thanks, This looks good to me.
Thank you for testing this! It is much appreciated.
I sent a v2 patch to the list last night. It passes the full test suite for me on cygwin 1.5, although there appears to be a slight performance problem on MinGW (perhaps!). :(
ATB, Ramsay Jones