git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9501: Do not use export X=Y

From
Torsten Bögershausen <tboegi@web.de>
Date
Apr 26, 2013, 09:21 UTC
Message-ID
<517A4723.7050309@web.de>
In-Reply-To
<7va9om2v9z.fsf@alter.siamese.dyndns.org>
On 2013-04-25 22.46, Junio C Hamano wrote:
Show 11 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes:
> 
>> Spilt lines like export X=Y into 2 lines:
>> X=Y
>> export X
> 
> That can be read from the patch text.
> 
> If you are going to spend three lines, please describe why it has to
> be split; that would help educate developers new to the codebase.
>

So true, writing good commit messages is not easy. and this was a good example for a bad example

Side questions: Which shells of which OS/distribution do not understand export X=Y?

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “t9501: Do not use export X=Y”
  1. t9501: Do not use export X=YTorsten Bögershausen, Apr 25, 2013
  2. Junio C HamanoApr 25, 2013
  3. Torsten BögershausenApr 26, 2013
  4. Junio C HamanoApr 26, 2013
  5. Rodrigo CamposApr 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.