patcht9501: Do not use export X=Y

> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
>  t/t9501-gitweb-standalone-http-status.sh | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh
> index ef86948..d3a5bac 100755
> --- a/t/t9501-gitweb-standalone-http-status.sh
> +++ b/t/t9501-gitweb-standalone-http-status.sh
> @@ -130,7 +130,8 @@ test_expect_success DATE_PARSER 'modification: feed last-modified' '
>  test_debug 'cat gitweb.headers'
>  
>  test_expect_success DATE_PARSER 'modification: feed if-modified-since (modified)' '
> -	export HTTP_IF_MODIFIED_SINCE="Wed, 6 Apr 2005 22:14:13 +0000" &&
> +	HTTP_IF_MODIFIED_SINCE="Wed, 6 Apr 2005 22:14:13 +0000" &&
> +	export HTTP_IF_MODIFIED_SINCE &&
>  	test_when_finished "unset HTTP_IF_MODIFIED_SINCE" &&
>  	gitweb_run "p=.git;a=atom;h=master" &&
>  	grep "Status: 200 OK" gitweb.headers
> @@ -138,7 +139,8 @@ test_expect_success DATE_PARSER 'modification: feed if-modified-since (modified)
>  test_debug 'cat gitweb.headers'
>  
>  test_expect_success DATE_PARSER 'modification: feed if-modified-since (unmodified)' '
> -	export HTTP_IF_MODIFIED_SINCE="Thu, 7 Apr 2005 22:14:13 +0000" &&
> +	HTTP_IF_MODIFIED_SINCE="Thu, 7 Apr 2005 22:14:13 +0000" &&
> +	export HTTP_IF_MODIFIED_SINCE &&
>  	test_when_finished "unset HTTP_IF_MODIFIED_SINCE" &&
>  	gitweb_run "p=.git;a=atom;h=master" &&
>  	grep "Status: 304 Not Modified" gitweb.headers
> @@ -153,7 +155,8 @@ test_expect_success DATE_PARSER 'modification: snapshot last-modified' '
>  test_debug 'cat gitweb.headers'
>  
>  test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (modified)' '
> -	export HTTP_IF_MODIFIED_SINCE="Wed, 6 Apr 2005 22:14:13 +0000" &&
> +	HTTP_IF_MODIFIED_SINCE="Wed, 6 Apr 2005 22:14:13 +0000" &&
> +	export HTTP_IF_MODIFIED_SINCE &&
>  	test_when_finished "unset HTTP_IF_MODIFIED_SINCE" &&
>  	gitweb_run "p=.git;a=snapshot;h=master;sf=tgz" &&
>  	grep "Status: 200 OK" gitweb.headers
> @@ -161,7 +164,8 @@ test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (modif
>  test_debug 'cat gitweb.headers'
>  
>  test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (unmodified)' '
> -	export HTTP_IF_MODIFIED_SINCE="Thu, 7 Apr 2005 22:14:13 +0000" &&
> +	HTTP_IF_MODIFIED_SINCE="Thu, 7 Apr 2005 22:14:13 +0000" &&
> +	export HTTP_IF_MODIFIED_SINCE &&
>  	test_when_finished "unset HTTP_IF_MODIFIED_SINCE" &&
>  	gitweb_run "p=.git;a=snapshot;h=master;sf=tgz" &&
>  	grep "Status: 304 Not Modified" gitweb.headers
> @@ -170,7 +174,8 @@ test_debug 'cat gitweb.headers'
>  
>  test_expect_success DATE_PARSER 'modification: tree snapshot' '
>  	ID=`git rev-parse --verify HEAD^{tree}` &&
> -	export HTTP_IF_MODIFIED_SINCE="Wed, 6 Apr 2005 22:14:13 +0000" &&
> +	HTTP_IF_MODIFIED_SINCE="Wed, 6 Apr 2005 22:14:13 +0000" &&
> +	export HTTP_IF_MODIFIED_SINCE &&
>  	test_when_finished "unset HTTP_IF_MODIFIED_SINCE" &&
>  	gitweb_run "p=.git;a=snapshot;h=$ID;sf=tgz" &&
>  	grep "Status: 200 OK" gitweb.headers &&

> Torsten Bögershausen <tboegi@web.de> writes:
> 
>> Spilt lines like export X=Y into 2 lines:
>> X=Y
>> export X
> 
> That can be read from the patch text.
> 
> If you are going to spend three lines, please describe why it has to
> be split; that would help educate developers new to the codebase.
> 

> On 2013-04-25 22.46, Junio C Hamano wrote:
>> Torsten Bögershausen <tboegi@web.de> writes:
>> 
>>> Spilt lines like export X=Y into 2 lines:
>>> X=Y
>>> export X
>> 
>> That can be read from the patch text.
>> 
>> If you are going to spend three lines, please describe why it has to
>> be split; that would help educate developers new to the codebase.
>> 
> So true,
> writing good commit messages is not easy.
> and this was a good example for a bad example
>
> Side questions:
> Which shells of which OS/distribution do not understand export X=Y?

> Torsten Bögershausen <tboegi@web.de> writes:
> 
> > On 2013-04-25 22.46, Junio C Hamano wrote:
> >> Torsten Bögershausen <tboegi@web.de> writes:
> >> 
> >>> Spilt lines like export X=Y into 2 lines:
> >>> X=Y
> >>> export X
> >
> > Side questions:
> > Which shells of which OS/distribution do not understand export X=Y?
> 
> I have not met one for quite some time myself. cf.