Re: [PATCH] t9501: Do not use export X=Y

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 26, 2013, 16:46 UTC
Message-ID: <7v38udz1da.fsf@alter.siamese.dyndns.org>
In-Reply-To: <517A4723.7050309@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 18 quoted lines

> On 2013-04-25 22.46, Junio C Hamano wrote:
>> Torsten Bögershausen <tboegi@web.de> writes:
>> 
>>> Spilt lines like export X=Y into 2 lines:
>>> X=Y
>>> export X
>> 
>> That can be read from the patch text.
>> 
>> If you are going to spend three lines, please describe why it has to
>> be split; that would help educate developers new to the codebase.
>> 
> So true,
> writing good commit messages is not easy.
> and this was a good example for a bad example
>
> Side questions:
> Which shells of which OS/distribution do not understand export X=Y?

I have not met one for quite some time myself. cf.

http://thread.gmane.org/gmane.comp.version-control.git/35543/focus=35551