From: Torsten Bögershausen Date: Fri, 26 Apr 2013 09:21:39 GMT Subject: Re: [PATCH] t9501: Do not use export X=Y Message-ID: <517A4723.7050309@web.de> In-Reply-To: <7va9om2v9z.fsf@alter.siamese.dyndns.org> On 2013-04-25 22.46, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> Spilt lines like export X=Y into 2 lines: >> X=Y >> export X > > That can be read from the patch text. > > If you are going to spend three lines, please describe why it has to > be split; that would help educate developers new to the codebase. > So true, writing good commit messages is not easy. and this was a good example for a bad example Side questions: Which shells of which OS/distribution do not understand export X=Y?