Re: [PATCH 2/2] add: refuse to add paths beyond repository boundaries

From: Jakub Narębski <jnareb@gmail.com>
Date: Apr 9, 2013, 18:58 UTC
Message-ID: <516464E4.10503@gmail.com>
In-Reply-To: <7v61zvsfkj.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 13 quoted lines

> Jakub Narębski <jnareb@gmail.com> writes:
> 
>> W dniu 09.04.2013 19:34, Junio C Hamano pisze:
>>
>>> -	if (has_symlink_leading_path(path, len))
>>> -		return error("'%s' is beyond a symbolic link", path);
>>> +	if (path_outside_our_project(path, len))
>>> +		return error("'%s' is outside our working tree", path);
>>>  
>>
>> Don't we lose important information here?  Or we shouldn't care?
> 
> What important information is it?

That the cause is symbolic link (or other git repository, in the future).

-- 
Jakub Narębski

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.