Re: [PATCH] t3700 (add): add failing test for add with submodules

From: Jeff King <peff@peff.net>
Date: Apr 8, 2013, 22:07 UTC
Message-ID: <20130408220730.GA11873@sigill.intra.peff.net>
In-Reply-To: <7v8v4svfwi.fsf@alter.siamese.dyndns.org>

On Mon, Apr 08, 2013 at 03:03:41PM -0700, Junio C Hamano wrote:

Show 23 quoted lines

> >> +test_expect_failure 'git add should not go past submodule boundaries' '
> >> +	mkdir submodule_dir &&
> >> +	(
> >> +		cd submodule_dir &&
> >> +		git init &&
> >> +		cat >foo <<-\EOF &&
> >> +		Some content
> >> +		EOF
> >> +		git add foo &&
> >> +		git commit -a -m "Add foo"
> >> +	) &&
> >> +	git add submodule_dir/foo
> >> +'
> >
> > That is not actually a submodule, but rather just a repo that happens to
> > be inside our working tree. 
> 
> I think we should treat it as a submodule-to-be, waiting for the
> user to run "git add submodule_dir".
> 
> If it is a file in the working tree of an unrelated and separate
> repository, it still is wrong to allow it to be added to our
> repository, no?

Sorry if I wasn't clear; I absolutely think this test is checking something reasonable, and we should fix it to pass. I was only referring to the wording, which is misleading (and hoped that pointing it out would help whoever works on it in the right direction of where the problem is).

-Peff