From: Jakub Narębski Date: Tue, 09 Apr 2013 18:58:44 GMT Subject: Re: [PATCH 2/2] add: refuse to add paths beyond repository boundaries Message-ID: <516464E4.10503@gmail.com> In-Reply-To: <7v61zvsfkj.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Jakub Narębski writes: > >> W dniu 09.04.2013 19:34, Junio C Hamano pisze: >> >>> - if (has_symlink_leading_path(path, len)) >>> - return error("'%s' is beyond a symbolic link", path); >>> + if (path_outside_our_project(path, len)) >>> + return error("'%s' is outside our working tree", path); >>> >> >> Don't we lose important information here? Or we shouldn't care? > > What important information is it? That the cause is symbolic link (or other git repository, in the future). -- Jakub Narębski