Re: [PATCH] t3700 (add): add failing test for add with submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 8, 2013, 15:07 UTC
Message-ID: <7vtxnhysb8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8CCepx5njpMo40608vHf5mQ_VfeZA_e5KDaH98V8_o0-w@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 18 quoted lines

> On Mon, Apr 8, 2013 at 8:26 PM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
>> +test_expect_failure 'git add should not go past submodule boundaries' '
>> +       mkdir submodule_dir &&
>> +       (
>> +               cd submodule_dir &&
>> +               git init &&
>> +               cat >foo <<-\EOF &&
>> +               Some content
>> +               EOF
>> +               git add foo &&
>> +               git commit -a -m "Add foo"
>> +       ) &&
>> +       git add submodule_dir/foo
>
> Thanks. I yhink the last line above should be "test_must_fail git add
> ...". I'm half way of fixing it (I think treat_leading_directory is a
> bit loose). Will continue tomorrow (or this weekend, depending on
> $DAYJOB)

This is a good thing to test (to make sure "add" fails, as you pointed out). Can you include a fixed one in your series?

Thanks.