Re: [PATCH] t3200: test branch creation with -v
- From
Michael J Gruber <git@drmicha.warpmail.net>
- Date
- Sep 10, 2011, 13:29 UTC
- Message-ID
- <4E6B6647.7090802@drmicha.warpmail.net>
- In-Reply-To
- <20110909194357.GA31446@sigill.intra.peff.net>
Jeff King venit, vidit, dixit 09.09.2011 21:43:
Show 15 quoted lines
> On Fri, Sep 09, 2011 at 09:40:59PM +0200, Michael J Gruber wrote: > >> +test_expect_success 'git branch -v t should work' ' + git branch >> -v t && + test .git/refs/heads/t && > > test -f ? > > Also, don't we have test_path_is_file which yields slightly prettier > output (and maybe some portability benefits; I don't remember)? > >> + git branch -d t && + test ! -f .git/refs/heads/t > > Ditto for 'test_path_is_missing' here. > > -Peff
Well, I tried to follow the surrounding style. That t3200 could benefit from some attention, though, which I did not want to mix in with the issue at hand.
Michael