git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git svn : hook before 'git svn dcommit'

From
FHFrédéric Heitzmann <frederic.heitzmann@gmail.com>
Date
Jul 4, 2011, 05:54 UTC
Message-ID
<4E11558B.90708@gmail.com>
In-Reply-To
<vpq62njaxl2.fsf@bauges.imag.fr>
Le 03/07/2011 23:00, Matthieu Moy a écrit :
Show 12 quoted lines
> Frédéric Heitzmann<frederic.heitzmann@gmail.com>  writes:
>
>> The 'pre-svn-dcommit' hook is called by 'git svn dcommit' and can be used to
>> prevent some diff to be committed to a SVN repository. It may typically be
>> used to filter some intermediate patches, which were committed into git but
>> must not find their way to the SVN repository.
> Why 2 patches?
>
> We usually try to have each commit as correct as possible (e.g. when
> sending several patches, each commit should still pass the testsuite).
> With your 2-patches serie, the first commit has documentation for a
> feature which doesn't exist yet.

I find it easier to separate commits on documentation from code patch, especially for rereading and dicussing. However, if it is desirable to get them merged, I could do that easily.

As for the order : patch 1/2 : perl magic patch 2/2 : documentation update => the serie looks in the right order to me.

Previous: Matthieu MoyNext: Frédéric Heitzmann
Message 9 of 11 in “git svn : hook before 'git svn dcommit'”
  1. git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 2, 2011
  2. Matthieu MoyJul 2, 2011
  3. Frédéric HeitzmannJul 2, 2011
  4. Matthieu MoyJul 2, 2011
  5. git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 3, 2011
  6. 1/2 git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 3, 2011
  7. 2/2 git svn : documentation of 'pre-svn-dcommit'Frédéric Heitzmann, Jul 3, 2011
  8. Matthieu MoyJul 3, 2011
  9. Frédéric HeitzmannJul 4, 2011
  10. git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 5, 2011
  11. git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.