From: Frédéric Heitzmann Date: Mon, 04 Jul 2011 05:54:19 GMT Subject: Re: [PATCH] git svn : hook before 'git svn dcommit' Message-ID: <4E11558B.90708@gmail.com> In-Reply-To: Le 03/07/2011 23:00, Matthieu Moy a écrit : > Frédéric Heitzmann writes: > >> The 'pre-svn-dcommit' hook is called by 'git svn dcommit' and can be used to >> prevent some diff to be committed to a SVN repository. It may typically be >> used to filter some intermediate patches, which were committed into git but >> must not find their way to the SVN repository. > Why 2 patches? > > We usually try to have each commit as correct as possible (e.g. when > sending several patches, each commit should still pass the testsuite). > With your 2-patches serie, the first commit has documentation for a > feature which doesn't exist yet. I find it easier to separate commits on documentation from code patch, especially for rereading and dicussing. However, if it is desirable to get them merged, I could do that easily. As for the order : patch 1/2 : perl magic patch 2/2 : documentation update => the serie looks in the right order to me.