git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git svn : hook before 'git svn dcommit'

From
FHFrédéric Heitzmann <frederic.heitzmann@gmail.com>
Date
Jul 3, 2011, 20:49 UTC
Message-ID
<1309726156-31156-2-git-send-email-frederic.heitzmann@gmail.com>
In-Reply-To
<1309726156-31156-1-git-send-email-frederic.heitzmann@gmail.com>

The 'pre-svn-dcommit' hook is called before 'git svn dcommit', which aborts if return value is not zero.

Signed-off-by: Frédéric Heitzmann <frederic.heitzmann@gmail.com>
---
 git-svn.perl |   21 +++++++++++++++++++++
 1 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 89f83fd..a537858 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -396,6 +396,25 @@ sub init_subdir {
 	$_repository = Git->repository(Repository => $ENV{GIT_DIR});
 }
 
+sub pre_svn_dcommit_hook {
+	my $head = shift;
+
+	my $hook = "$ENV{GIT_DIR}/hooks/pre-svn-dcommit";
+	return 0 if ! -e $hook || ! -x $hook;
+
+	system($hook, $head);
+	if ($? == -1) {
+		print "[pre_svn_dcommit_hook] failed to execute $hook: $!\n";
+		return 1;
+	} elsif ($? & 127) {
+		printf "[pre_svn_dcommit_hook] child died with signal %d, %s coredump\n",
+		($? & 127),  ($? & 128) ? 'with' : 'without';
+		return 1;
+	} else {
+		return $? >> 8;
+	}
+}
+
 sub cmd_clone {
 	my ($url, $path) = @_;
 	if (!defined $path &&
@@ -505,6 +524,8 @@ sub cmd_dcommit {
 		. "or stash them with `git stash'.\n";
 	$head ||= 'HEAD';
 
+	return if pre_svn_dcommit_hook($head);
+
 	my $old_head;
 	if ($head ne 'HEAD') {
 		$old_head = eval {
-- 
1.7.6.133.gd3b55a
Previous: Frédéric HeitzmannNext: Frédéric Heitzmann
Message 6 of 11 in “git svn : hook before 'git svn dcommit'”
  1. git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 2, 2011
  2. Matthieu MoyJul 2, 2011
  3. Frédéric HeitzmannJul 2, 2011
  4. Matthieu MoyJul 2, 2011
  5. git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 3, 2011
  6. 1/2 git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 3, 2011
  7. 2/2 git svn : documentation of 'pre-svn-dcommit'Frédéric Heitzmann, Jul 3, 2011
  8. Matthieu MoyJul 3, 2011
  9. Frédéric HeitzmannJul 4, 2011
  10. git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 5, 2011
  11. git svn : hook before 'git svn dcommit'Frédéric Heitzmann, Jul 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.