git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH V2 4/5] git-grep: Learn PCRE

From
Johannes Sixt <j.sixt@viscovery.net>
Date
May 5, 2011, 06:28 UTC
Message-ID
<4DC24371.7060906@viscovery.net>
In-Reply-To
<1304546421-25439-5-git-send-email-michal.kiedrowicz@gmail.com>
Am 5/5/2011 0:00, schrieb Michał Kiedrowicz:
> +# Define NO_LIBPCRE if you do not have libpcre installed.

This makes libpcre a requirement with an opt-out. But I can imagine that there are many platforms where libpcre is not installed. We would have to add NO_LIBPRCE=1 to many platform configuration sections. But how can this setting be countermanded if someone does install libpcre on such a platform?

Wouldn't it be better to make this an opt-in (USE_LIBPCRE)?
-- Hannes
Previous: Michal KiedrowiczNext: Michal Kiedrowicz
Message 13 of 16 in “Add PCRE support to git-grep”
  1. 0/5 Add PCRE support to git-grepMichał Kiedrowicz, May 4, 2011
  2. 1/5 Documentation: Add --line-number to git-grep synopsisMichał Kiedrowicz, May 4, 2011
  3. 2/5 contrib/completion: --line-number to git grepMichał Kiedrowicz, May 4, 2011
  4. 3/5 grep: Put calls to fixmatch() and regmatch() into patmatch()Michał Kiedrowicz, May 4, 2011
  5. 4/5 git-grep: Learn PCREMichał Kiedrowicz, May 4, 2011
  6. Junio C HamanoMay 5, 2011
  7. Bert WesargMay 5, 2011
  8. Junio C HamanoMay 5, 2011
  9. Johannes SixtMay 5, 2011
  10. Michal KiedrowiczMay 5, 2011
  11. Johannes SixtMay 5, 2011
  12. Michal KiedrowiczMay 5, 2011
  13. Johannes SixtMay 5, 2011
  14. Michal KiedrowiczMay 5, 2011
  15. Alex RiesenMay 5, 2011
  16. 5/5 configure: Check for libpcreMichał Kiedrowicz, May 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.