Re: [PATCH V2 4/5] git-grep: Learn PCRE

From: Junio C Hamano <gitster@pobox.com>
Date: May 5, 2011, 01:09 UTC
Message-ID: <7vk4e6c5rh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1304546421-25439-5-git-send-email-michal.kiedrowicz@gmail.com>

Michał Kiedrowicz <michal.kiedrowicz@gmail.com> writes:

Show 10 quoted lines

> diff --git a/Makefile b/Makefile
> index 3a1fe20..98841dc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -24,6 +24,12 @@ all::
>  # Define NO_OPENSSL environment variable if you do not have OpenSSL.
>  # This also implies BLK_SHA1.
>  #
> +# Define NO_LIBPCRE if you do not have libpcre installed.  git-grep cannot use
> +# Perl-compatible regexes.

At least at first, I'd rather want to keep this an optional feature, i.e.

+# Define WITH_LIBPCRE if you have and want to use libpcre.

Show 6 quoted lines

> @@ -33,6 +39,8 @@ struct grep_pat {
>  	size_t patternlen;
>  	enum grep_header_field field;
>  	regex_t regexp;
> +	pcre *pcre_regexp;
> +	pcre_extra *extra;

I don't think pcre will forever stay the _only_ thing that wants to hook an extra information to this structure. That is why I included "pcre_" in the field name in my earlier "how about doing it this way" suggestion.