git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH V2 4/5] git-grep: Learn PCRE

From
Michal Kiedrowicz <michal.kiedrowicz@gmail.com>
Date
May 5, 2011, 08:38 UTC
Message-ID
<20110505103839.2a051583@mkiedrowicz>
In-Reply-To
<4DC2567A.1060502@viscovery.net>
On 05.05.2011 09:49:14 +0200 Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 8 quoted lines
> Am 5/5/2011 9:41, schrieb Michal Kiedrowicz:
> > But I can abstract these calls to die_pcre_not_supported() to not
> > repeat die() message.
> 
> Gah! Don't over-engineer. The compiler will un-duplicate the message
> texts for you if you carefully copy-and-paste them.
> 
> -- Hannes

The whole point of using die_pcre_not_supported() is that it'll take care of this "if you carefully copy-and-paste them" and remove redundancy in _source code_, not binary. But still these die()'s are minor nit (IMO).

Previous: Johannes SixtNext: Johannes Sixt
Message 12 of 16 in “Add PCRE support to git-grep”
  1. 0/5 Add PCRE support to git-grepMichał Kiedrowicz, May 4, 2011
  2. 1/5 Documentation: Add --line-number to git-grep synopsisMichał Kiedrowicz, May 4, 2011
  3. 2/5 contrib/completion: --line-number to git grepMichał Kiedrowicz, May 4, 2011
  4. 3/5 grep: Put calls to fixmatch() and regmatch() into patmatch()Michał Kiedrowicz, May 4, 2011
  5. 4/5 git-grep: Learn PCREMichał Kiedrowicz, May 4, 2011
  6. Junio C HamanoMay 5, 2011
  7. Bert WesargMay 5, 2011
  8. Junio C HamanoMay 5, 2011
  9. Johannes SixtMay 5, 2011
  10. Michal KiedrowiczMay 5, 2011
  11. Johannes SixtMay 5, 2011
  12. Michal KiedrowiczMay 5, 2011
  13. Johannes SixtMay 5, 2011
  14. Michal KiedrowiczMay 5, 2011
  15. Alex RiesenMay 5, 2011
  16. 5/5 configure: Check for libpcreMichał Kiedrowicz, May 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.