From: Johannes Sixt <j.sixt@viscovery.net>
Date: Thu, 05 May 2011 06:28:01 GMT
Subject: Re: [PATCH V2 4/5] git-grep: Learn PCRE
Message-ID: <4DC24371.7060906@viscovery.net>
In-Reply-To: <1304546421-25439-5-git-send-email-michal.kiedrowicz@gmail.com>

Am 5/5/2011 0:00, schrieb Michał Kiedrowicz:
> +# Define NO_LIBPCRE if you do not have libpcre installed.

This makes libpcre a requirement with an opt-out. But I can imagine that
there are many platforms where libpcre is not installed. We would have to
add NO_LIBPRCE=1 to many platform configuration sections. But how can this
setting be countermanded if someone does install libpcre on such a platform?

Wouldn't it be better to make this an opt-in (USE_LIBPCRE)?

-- Hannes