Re: [PATCH 6/7] commit,status: describe -u likewise
- From
- Michael J Gruber <drmicha@warpmail.net>
- Date
- Feb 15, 2011, 06:53 UTC
- Message-ID
- <4D5A22D3.2080605@warpmail.net>
- In-Reply-To
- <7vei7as82n.fsf@alter.siamese.dyndns.org>
Junio C Hamano venit, vidit, dixit 14.02.2011 20:57:
Show 21 quoted lines
> Michael J Gruber <git@drmicha.warpmail.net> writes:
>
>> They differ by one character only. Being exactly equal should help
>> translations.
>>
>> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
>> ---
>> diff --git a/builtin/commit.c b/builtin/commit.c
>> index 8a534de..ef2114b 100644
>> --- a/builtin/commit.c
>> +++ b/builtin/commit.c
>> @@ -150,7 +150,7 @@ static struct option builtin_commit_options[] = {
>> ...
>> - { OPTION_STRING, 'u', "untracked-files", &untracked_files_arg, "mode", "show untracked files, optional modes: all, normal, no (Default: all)", PARSE_OPT_OPTARG, NULL, (intptr_t)"all" },
>> + { OPTION_STRING, 'u', "untracked-files", &untracked_files_arg, "mode", "show untracked files, optional modes: all, normal, no. (Default: all)", PARSE_OPT_OPTARG, NULL, (intptr_t)"all" },
>
> Makes sense; thanks.
>
> I however wonder if we have an opportunity for even more unifying these
> two arrays, typing the same thing only once.
> I was surprised we have two arrays at all, "status" being "commit --dry-run". I'll check whether we can remove redundancy without too much effort.
Michael