git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/7] commit,status: describe -u likewise

From
Jeff King <peff@peff.net>
Date
Feb 15, 2011, 07:21 UTC
Message-ID
<20110215072148.GC28634@sigill.intra.peff.net>
In-Reply-To
<4D5A22D3.2080605@warpmail.net>
On Tue, Feb 15, 2011 at 07:53:07AM +0100, Michael J Gruber wrote:
Show 6 quoted lines
> > I however wonder if we have an opportunity for even more unifying
> > these two arrays, typing the same thing only once.
> 
> I was surprised we have two arrays at all, "status" being "commit
> --dry-run". I'll check whether we can remove redundancy without too
> much effort.

Hmm, not according to 9e4b7ab (git status: not "commit --dry-run" anymore, 2009-08-15).

"Commit --dry-run" more-or-less runs status on the index that would be committed. But it obviously takes a lot of options that status does not, and in theory status could take options that "commit --dry-run" does not (certainly its non-option arguments are different these days, but parse_options doesn't care about that).

I said "in theory" because I have no idea if such options exist yet or not. But probably any refactoring should pull out the common options into a shared list, and not simply make commit a superset of the status options.

-Peff
Previous: Michael J GruberNext: Michael J Gruber
Message 19 of 36 in “Cleaning up --help-all inconsistencies”
  1. 0/7 Cleaning up --help-all inconsistenciesMichael J Gruber, Feb 14, 2011
  2. 1/7 commit,tag: use same wording for -FMichael J Gruber, Feb 14, 2011
  3. Junio C HamanoFeb 14, 2011
  4. 2/7 push: describe --porcelain just like commit and statusMichael J Gruber, Feb 14, 2011
  5. Johannes SixtFeb 14, 2011
  6. Junio C HamanoFeb 14, 2011
  7. Sverre RabbelierFeb 14, 2011
  8. Michael J GruberFeb 15, 2011
  9. 3/7 clone,init: describe --template using the same wordingMichael J Gruber, Feb 14, 2011
  10. Junio C HamanoFeb 14, 2011
  11. 4/7 merge,tag: describe -m just like commitMichael J Gruber, Feb 14, 2011
  12. Junio C HamanoFeb 14, 2011
  13. Michael J GruberFeb 15, 2011
  14. Junio C HamanoFeb 15, 2011
  15. 5/7 add: describe --patch like checkout, resetMichael J Gruber, Feb 14, 2011
  16. 6/7 commit,status: describe -u likewiseMichael J Gruber, Feb 14, 2011
  17. Junio C HamanoFeb 14, 2011
  18. Michael J GruberFeb 15, 2011
  19. Jeff KingFeb 15, 2011
  20. 7/7 git-tag.txt: list all modes in the descriptionMichael J Gruber, Feb 14, 2011
  21. Junio C HamanoFeb 14, 2011
  22. 00/10 Cleaning up --help-all inconsistenciesMichael J Gruber, Feb 15, 2011
  23. Junio C HamanoFeb 15, 2011
  24. Michael J GruberFeb 16, 2011
  25. Junio C HamanoFeb 16, 2011
  26. Make <identifier> lowercase in DocumentationMichael J Gruber, Feb 17, 2011
  27. 01/10 commit,tag: use same wording for -FMichael J Gruber, Feb 15, 2011
  28. 02/10 commit,status: describe --porcelain just like pushMichael J Gruber, Feb 15, 2011
  29. 03/10 clone,init: describe --template using the same wordingMichael J Gruber, Feb 15, 2011
  30. 04/10 commit,merge,tag: describe -m likewiseMichael J Gruber, Feb 15, 2011
  31. 05/10 add: describe --patch like checkout, resetMichael J Gruber, Feb 15, 2011
  32. 06/10 commit,status: describe -u likewiseMichael J Gruber, Feb 15, 2011
  33. 07/10 git-tag.txt: list all modes in the descriptionMichael J Gruber, Feb 15, 2011
  34. 08/10 Make <identifier> lowercase as per CodingGuidelinesMichael J Gruber, Feb 15, 2011
  35. 09/10 Make <identifier> lowercase as per CodingGuidelinesMichael J Gruber, Feb 15, 2011
  36. 10/10 Make <identifier> lowercase as per CodingGuidelinesMichael J Gruber, Feb 15, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.