Re: [PATCH 2/3] Submodules: Add the new "fetch" config option for fetch and pull
- From
Jens Lehmann <jens.lehmann@web.de>
- Date
- Oct 9, 2010, 19:22 UTC
- Message-ID
- <4CB0C0DC.40108@web.de>
- In-Reply-To
- <AANLkTikUdNdDDK9-+AjuSO_RJHNBZEp5mHPRnsV0Fo0v@mail.gmail.com>
Am 07.10.2010 15:33, schrieb Jon Seymour:
Show 16 quoted lines
>> The .gitmodules file is parsed for "submodule.<name>.fetch" entries before >> looking for them in .git/config. Thus settings found in .git/config will >> override those from .gitmodules, thereby allowing the local developer to >> ignore settings given by the remote side while also letting upstream set >> defaults for those users who don't have special needs. >> > > I wonder if the name is a little too general for the function of this > configuration variable and if it might not be better to qualify it a > little further, perhaps > with the recursive suffix, e.g.: > > submodule.<name>.fetch.recursive > > This would allow us to define other attributes that configure fetch on > a per submodule basis later should the need arise.
I think that's a valid point (especially as we might add the --recursive option to other commands too). I will change the option name as proposed in the next version.