Re: [PATCH] fetch: Get submodule paths from index and not from .gitmodules

From: Jens Lehmann <jens.lehmann@web.de>
Date: Sep 17, 2010, 11:31 UTC
Message-ID: <4C9351A7.7050609@web.de>
In-Reply-To: <AF9B7F7E-0956-4814-A3A8-BAD7619A043D@sb.org>

Am 16.09.2010 21:29, schrieb Kevin Ballard:

> Unfortunately, the only effect this had was to change the order of fetches
> (it now appears to be case-sensitive alphabetical).

Yup, this is a side effect of using the index instead of the .gitmodules file.

But I think I found the real issue, the stdout of the forked "git fetch" was swallowed due to a copy & paste bug while the actual fetch commands were executed nonetheless. Please try the following change:

diff --git a/submodule.c b/submodule.c
index e2c3bae..4fb1071 100644
--- a/submodule.c
+++ b/submodule.c
@@ -260,7 +260,8 @@ int fetch_populated_submodules(int forced)
        cp.env = local_repo_env;
        cp.git_cmd = 1;
        cp.no_stdin = 1;
-       cp.out = -1;
+       cp.out = 1;
+       cp.err = 1;

        for (i = 0; i < active_nr; i++) {
                struct strbuf submodule_path = STRBUF_INIT;