Re: [PATCH] send-email: lazily assign editor variable

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Mar 23, 2010, 10:56 UTC
Message-ID: <4BA89E53.3000201@drmicha.warpmail.net>
In-Reply-To: <20100323005806.GA9335@progeny.tock>

Jonathan Nieder venit, vidit, dixit 23.03.2010 01:58:

Show 16 quoted lines

> Michael J Gruber wrote:
> 
>> b4479f0 (add -i, send-email, svn, p4, etc: use "git var GIT_EDITOR",
>> 2009-10-30) introduced the use of git var GIT_EDITOR which may lead to
>> problems when send-mail is used without a tty.
>>
>> Therefore, use git var GIT_EDITOR only when we actually edit something.
>>
>> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
>> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> FWIW:
> 
>   Acked-by: Jonathan Nieder <jrnieder@gmail.com>
> 
> Next time, please CC me.

Yep, sorry for the omission.

Michael