git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[REGRESSION] git var GIT_EDITOR fails without tty

From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date
Mar 22, 2010, 14:59 UTC
Message-ID
<20100322145947.GA1709@pengutronix.de>
Hello,

since b4479f074760a788dd4e353b8c86a7d735afc53e git send-email (and others) use git var GIT_EDITOR. This is OK as such but it breaks the post-receive hooks that I use on several repositories.

When called they don't have a tty, and this makes git var fail:
	user@host:~$ ssh localhost "git var GIT_EDITOR"
	fatal: Terminal is dumb, but EDITOR unset

IMHO git send-email should only call $(git var GIT_EDITOR) when it actually needs it.

(Note I'm using the Debian packaged version of git. I don't think this problem is Debian specific, I didn't check though.)

Best regards Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Next: Michael J Gruber
Message 1 of 14 in “[REGRESSION] git var GIT_EDITOR fails without tty”
  1. Uwe Kleine-KönigMar 22, 2010
  2. send-email: lazily assign editor variableMichael J Gruber, Mar 22, 2010
  3. Uwe Kleine-KönigMar 22, 2010
  4. Jonathan NiederMar 23, 2010
  5. Michael J GruberMar 23, 2010
  6. Junio C HamanoMar 24, 2010
  7. Jonathan NiederMar 25, 2010
  8. Junio C HamanoMar 26, 2010
  9. Jonathan NiederMar 26, 2010
  10. Michael J GruberMar 25, 2010
  11. Junio C HamanoMar 26, 2010
  12. send-email: do not check for editor until neededJonathan Nieder, Mar 22, 2010
  13. Peter KjellerstedtMar 23, 2010
  14. Jonathan NiederMar 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.