git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: lazily assign editor variable

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Mar 23, 2010, 00:58 UTC
Message-ID
<20100323005806.GA9335@progeny.tock>
In-Reply-To
<eb0d92cf28820eb9783e789a8c4c62c3af4dd0d0.1269274203.git.git@drmicha.warpmail.net>
Michael J Gruber wrote:
Show 8 quoted lines
> b4479f0 (add -i, send-email, svn, p4, etc: use "git var GIT_EDITOR",
> 2009-10-30) introduced the use of git var GIT_EDITOR which may lead to
> problems when send-mail is used without a tty.
> 
> Therefore, use git var GIT_EDITOR only when we actually edit something.
> 
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
FWIW:
  Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Next time, please CC me.

Thanks, Jonathan

Previous: Uwe Kleine-KönigNext: Michael J Gruber
Message 4 of 14 in “[REGRESSION] git var GIT_EDITOR fails without tty”
  1. Uwe Kleine-KönigMar 22, 2010
  2. send-email: lazily assign editor variableMichael J Gruber, Mar 22, 2010
  3. Uwe Kleine-KönigMar 22, 2010
  4. Jonathan NiederMar 23, 2010
  5. Michael J GruberMar 23, 2010
  6. Junio C HamanoMar 24, 2010
  7. Jonathan NiederMar 25, 2010
  8. Junio C HamanoMar 26, 2010
  9. Jonathan NiederMar 26, 2010
  10. Michael J GruberMar 25, 2010
  11. Junio C HamanoMar 26, 2010
  12. send-email: do not check for editor until neededJonathan Nieder, Mar 22, 2010
  13. Peter KjellerstedtMar 23, 2010
  14. Jonathan NiederMar 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.