git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Optimized cvsexportcommit: calling 'cvs status' only once instead of once per changed file.

From
Steffen Prohaska <prohaska@zib.de>
Date
May 9, 2007, 11:43 UTC
Message-ID
<4BA4CF7D-40CB-4A55-ADDC-56DE179FD6C1@zib.de>
In-Reply-To
<Pine.LNX.4.64.0705091303280.4167@racer.site>
Hello,
On May 9, 2007, at 1:04 PM, Johannes Schindelin wrote:
Show 10 quoted lines
> On Wed, 9 May 2007, Steffen Prohaska wrote:
>
>> The old implementation executed 'cvs status' for each file touched by
>> the patch to be applied.
>
> I did not follow development of that script closely, but could it  
> be that
> this is a safety valve, to make it unlikely to commit something  
> which was
> changed by somebody else in the meantime?

Right. My patch doesn't change the functionality of the safety check. It's just a magnitude faster if you commit a lot of files. I'm now able to apply a patch that changes 900 files to a cvs working copy using ssh over DSL. I wasn't before, at least not in reasonable time.

Another solution would be to make the safety checks optional as they are not needed for the core functionality. If you have a clean, up-to- date cvs working copy you're fine.

- Steffen
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 5 of 15 in “Optimized cvsexportcommit: calling 'cvs status' only once instead of once per changed file.”
  1. Optimized cvsexportcommit: calling 'cvs status' only once instead of once per changed file.Steffen Prohaska, May 8, 2007
  2. Steffen ProhaskaMay 9, 2007
  3. Optimized cvsexportcommit: calling 'cvs status' only once instead of once per changed file.Steffen Prohaska, May 9, 2007
  4. Johannes SchindelinMay 9, 2007
  5. Steffen ProhaskaMay 9, 2007
  6. Johannes SchindelinMay 9, 2007
  7. Steffen ProhaskaMay 9, 2007
  8. Robin RosenbergMay 9, 2007
  9. Steffen ProhaskaMay 9, 2007
  10. Optimized cvsexportcommit: calling 'cvs status' once instead of once per touched file.Steffen Prohaska, May 9, 2007
  11. Martin LanghoffMay 10, 2007
  12. Junio C HamanoMay 10, 2007
  13. RFH for [PATCH] Optimized cvsexportcommit: calling 'cvs status' only once instead of once per changed file.Junio C Hamano, May 13, 2007
  14. Robin RosenbergMay 13, 2007
  15. Martin LanghoffMay 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.