Re: [PATCH] Optimized cvsexportcommit: calling 'cvs status' only once instead of once per changed file.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 9, 2007, 12:25 UTC
Message-ID: <Pine.LNX.4.64.0705091424190.4167@racer.site>
In-Reply-To: <4BA4CF7D-40CB-4A55-ADDC-56DE179FD6C1@zib.de>

Hi,

On Wed, 9 May 2007, Steffen Prohaska wrote:

Show 15 quoted lines

> On May 9, 2007, at 1:04 PM, Johannes Schindelin wrote:
> 
> > On Wed, 9 May 2007, Steffen Prohaska wrote:
> > 
> > > The old implementation executed 'cvs status' for each file touched by
> > > the patch to be applied.
> > 
> > I did not follow development of that script closely, but could it be that
> > this is a safety valve, to make it unlikely to commit something which was
> > changed by somebody else in the meantime?
> 
> Right. My patch doesn't change the functionality of the safety check. It's
> just a magnitude faster if you commit a lot of files. I'm now able to apply a
> patch that changes 900 files to a cvs working copy using ssh over DSL. I
> wasn't before, at least not in reasonable time.

What I was trying to get at: if you commit 900 files, and after the 450th file somebody _else_ commits a file, which just so happens to be one of your 450 remaining files, that safety check no longer holds.

CVS is slow.

Ciao, Dscho