Re: [PATCH] Optimized cvsexportcommit: calling 'cvs status' only once instead of once per changed file.
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 10, 2007, 07:08 UTC
- Message-ID
- <7vd519m9z7.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <46a038f90705092353x107c738foa7db547ab29b1748@mail.gmail.com>
"Martin Langhoff" <martin.langhoff@gmail.com> writes:
Show 13 quoted lines
> On 5/10/07, Steffen Prohaska <prohaska@zib.de> wrote: >> I'll post a patch soon that takes the best of both: Call cvs status >> once with the list of touched files and parse the output. Only one >> connection is needed and only the minimal amount of status data is >> transferred. > > Yes, please :-) I wrote cvsexportcommit originally, and use it on a > huge cvs checkout that is hosted on SF.net (slow!). My commits are > small (3~5 files). I agree with using only one connection so commits > with many files are sanity-checked faster, but status needs to ask > explicitly about the files it's about to touch. > > cheers,
Sounds like you are perfect guinea pig. A test in the real-life use followed by an Ack is very appreciated.