From: Steffen Prohaska Date: Wed, 09 May 2007 11:43:21 GMT Subject: Re: [PATCH] Optimized cvsexportcommit: calling 'cvs status' only once instead of once per changed file. Message-ID: <4BA4CF7D-40CB-4A55-ADDC-56DE179FD6C1@zib.de> In-Reply-To: Hello, On May 9, 2007, at 1:04 PM, Johannes Schindelin wrote: > On Wed, 9 May 2007, Steffen Prohaska wrote: > >> The old implementation executed 'cvs status' for each file touched by >> the patch to be applied. > > I did not follow development of that script closely, but could it > be that > this is a safety valve, to make it unlikely to commit something > which was > changed by somebody else in the meantime? Right. My patch doesn't change the functionality of the safety check. It's just a magnitude faster if you commit a lot of files. I'm now able to apply a patch that changes 900 files to a cvs working copy using ssh over DSL. I wasn't before, at least not in reasonable time. Another solution would be to make the safety checks optional as they are not needed for the core functionality. If you have a clean, up-to- date cvs working copy you're fine. - Steffen