git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH bg/format-patch-p-noop] log-tree: always add --- marker when options are patch and a stat

From
Stephen Boyd <bebarino@gmail.com>
Date
Nov 4, 2009, 07:35 UTC
Message-ID
<4AF12EC5.4030407@gmail.com>
In-Reply-To
<20091104071940.GA15011@coredump.intra.peff.net>
Jeff King wrote:
Show 9 quoted lines
>
> This patch unbreaks what 68daa64 did (while still preserving
> what 68daa64 was trying to do), reinstating "-p" to suppress
> the default behavior. We do this by parsing "-p" ourselves
> in format-patch, and noting whether it was used explicitly.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>   
This looks good to me; covering 2 and 3 of Junio's TODO list.
Show 8 quoted lines
> @@ -940,6 +941,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
>  		{ OPTION_CALLBACK, 0, "thread", &thread, "style",
>  			    "enable message threading, styles: shallow, deep",
>  			    PARSE_OPT_OPTARG, thread_callback },
> +		OPT_BOOLEAN('p', NULL, &use_patch_format,
> +			"show patch format instead of default (patch + stat)"),
>  		OPT_END()
>  	};

I don't imagine we want this option in the messaging group though. Can you move it up?

Previous: Jeff KingNext: Jeff King
Message 6 of 12 in “log-tree: always add --- marker when options are patch and a stat”
  1. log-tree: always add --- marker when options are patch and a statStephen Boyd, Nov 3, 2009
  2. Junio C HamanoNov 4, 2009
  3. Jeff KingNov 4, 2009
  4. Jeff KingNov 4, 2009
  5. Jeff KingNov 4, 2009
  6. Stephen BoydNov 4, 2009
  7. Jeff KingNov 4, 2009
  8. Junio C HamanoNov 4, 2009
  9. Björn GustavssonNov 4, 2009
  10. Junio C HamanoNov 4, 2009
  11. Björn GustavssonNov 4, 2009
  12. Junio C HamanoNov 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.