Re: [PATCH bg/format-patch-p-noop] log-tree: always add --- marker when options are patch and a stat
- From
Björn Gustavsson <bgustavsson@gmail.com>
- Date
- Nov 4, 2009, 07:00 UTC
- Message-ID
- <6672d0160911032300w1a2dfdbck5b1db98f2059639b@mail.gmail.com>
- In-Reply-To
- <7vy6mmltz9.fsf@alter.siamese.dyndns.org>
2009/11/4 Junio C Hamano <gitster@pobox.com>:
> In an ideal world, I would probably say: > > * format-patch should have three-dash after the commit message, no matter > what format the patch is asked for, and it always will give patch text.
I agree.
> * format-patch -p should be reinstated as a way to ask for "just patch > text, no diffstat". Introducing a new option --no-stat _in addition_ > to improve the UI is Ok.
Since -p has been broken for 14 months, is really necessary to reinstate it? (Or has the breakage not been reported because the people who care still use a git version older than 14 months?)
Why not just add a new --no-stat option?
> * format-patch -U<n> should not be mistaken as a request to suppress > diffstat; what 68daa64 _tried_ to do was worthy.
I agree.
/Björn
-- Björn Gustavsson, Erlang/OTP, Ericsson AB