From: Stephen Boyd <bebarino@gmail.com>
Date: Wed, 04 Nov 2009 07:35:33 GMT
Subject: Re: [PATCH bg/format-patch-p-noop] log-tree: always add --- marker when options are patch and a stat
Message-ID: <4AF12EC5.4030407@gmail.com>
In-Reply-To: <20091104071940.GA15011@coredump.intra.peff.net>

Jeff King wrote:
>
> This patch unbreaks what 68daa64 did (while still preserving
> what 68daa64 was trying to do), reinstating "-p" to suppress
> the default behavior. We do this by parsing "-p" ourselves
> in format-patch, and noting whether it was used explicitly.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>   

This looks good to me; covering 2 and 3 of Junio's TODO list.

> @@ -940,6 +941,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
>  		{ OPTION_CALLBACK, 0, "thread", &thread, "style",
>  			    "enable message threading, styles: shallow, deep",
>  			    PARSE_OPT_OPTARG, thread_callback },
> +		OPT_BOOLEAN('p', NULL, &use_patch_format,
> +			"show patch format instead of default (patch + stat)"),
>  		OPT_END()
>  	};

I don't imagine we want this option in the messaging group though. Can 
you move it up?