Re: [PATCH bg/format-patch-p-noop] log-tree: always add --- marker when options are patch and a stat
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 4, 2009, 07:31 UTC
- Message-ID
- <7vhbtakapf.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <6672d0160911032300w1a2dfdbck5b1db98f2059639b@mail.gmail.com>
Björn Gustavsson <bgustavsson@gmail.com> writes:
> Since -p has been broken for 14 months, is really necessary to reinstate > it? (Or has the breakage not been reported because the people who care > still use a git version older than 14 months?)
Oh, 1.6.0 has the old behaviour and we see many people still on 1.5.X series. Hopefully nobody uses 1.4.X series anymore but I wouldn't be overly surprised if somebody raised hand in the next 6 hours after seeing this message ;-)
> Why not just add a new --no-stat option?
I am all for teaching _new_ people to say "format-patch --no-stat", but it won't help people who have been happy with 1.6.0 when they update, if they have to change their "format-patch -p" to "format-patch --no-stat".