git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4202-log.sh: Test git log --no-walk sort order

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Jul 14, 2009, 12:38 UTC
Message-ID
<4A5C7C3A.9080506@drmicha.warpmail.net>
In-Reply-To
<4A5C785C.6060706@viscovery.net>
Johannes Sixt venit, vidit, dixit 14.07.2009 14:21:
Show 6 quoted lines
> Michael J Gruber schrieb:
>> +test_expect_success 'git log --no-walk <commits> sorts by commit time' '
> ...
>> +test_expect_success 'git show <commits> does not sort by commit time' '
> 
> Thanks, but sorry that I'm nit-picking here:

This not being my first patch, I don't expect any patch to go through without nit-picking here - which, in most cases, is really a good thing ;)

> You say what git show does
> not do, but shouldn't you say what git show should do?
> 
> 	'git show shows commits in command line order'

Well, I assumed "does not sort" == "leaves as is". But, even if it is, still "does not sort by commit time" != "leaves as is". v2 upcoming...

Michael
Previous: Johannes SixtNext: Michael J Gruber
Message 11 of 17 in “Make 'git show' more useful”
  1. Linus TorvaldsJul 13, 2009
  2. Junio C HamanoJul 13, 2009
  3. Re: Make 'git show' more usefulPaolo Bonzini, Jul 13, 2009
  4. Linus TorvaldsJul 14, 2009
  5. Johannes SchindelinJul 14, 2009
  6. Linus TorvaldsJul 14, 2009
  7. Paolo BonziniJul 14, 2009
  8. Johannes SchindelinJul 14, 2009
  9. t4202-log.sh: Test git log --no-walk sort orderMichael J Gruber, Jul 14, 2009
  10. Johannes SixtJul 14, 2009
  11. Michael J GruberJul 14, 2009
  12. [PATCHv2] t4202-log.sh: Test git log --no-walk sort orderMichael J Gruber, Jul 14, 2009
  13. Johannes SchindelinJul 14, 2009
  14. Michael J GruberJul 14, 2009
  15. t4202-log.sh: Test git log --no-walk sort orderMichael J Gruber, Jul 17, 2009
  16. Johannes SchindelinJul 17, 2009
  17. Johannes SchindelinJul 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.